Updated String library to use C++11 iterators. #2267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow using the String library in a ranged for loop:
```C++
String s("Hi, this is a test");
for (const char& ch : s) {
Serial.print(ch);
}
```
and even modify
```C++
String s("Hi, this is another test");
for (char& ch : s) {
ch++;
}
Serial.println(s);
```
Current coverage is 27.74%@@ master #2267 diff @@
==========================================
Files 20 20
Lines 3641 3640 -1
Methods 334 334
Messages 0 0
Branches 675 675
==========================================
- Hits 1011 1010 -1
Misses 2452 2452
Partials 178 178
|
|
It's a "fix" for #2224 |
slaff
pushed a commit
to slaff/Sming
that referenced
this pull request
May 30, 2017
slaff
added a commit
to SmingHub/Sming
that referenced
this pull request
Jun 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow using the String library in a ranged for loop:
and even modify